feature/spi-jpa-module #9

Merged

jbwittner merged 19 commits from feature/spi-jpa-module into develop 2026-06-04 15:50:11 +00:00

Conversation 0 Commits 19 Files changed 16 +277 -39

jbwittner commented 2026-06-04 15:38:47 +00:00

Owner

Copy link

No description provided.

jbwittner added 17 commits 2026-06-04 15:38:47 +00:00

feat: add infrastructure/spi-jpa Maven module ... 769f312941

Introduces the spi-jpa module with Spring Data JPA, Flyway, and
PostgreSQL driver. Imports the testcontainers-bom explicitly since
Spring Boot 4.x BOM sub-imports are not transitive in Maven.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add ExampleEntity, repository, and Flyway migration ... f025c35a96

Adds a placeholder JPA entity with UUID primary key (GenerationType.UUID),
its JpaRepository, and the initial Flyway migration V1 that creates
the example table.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: add Testcontainers integration test for ExampleEntityRepository ... f0112d42dd

Uses a minimal @SpringBootApplication entry point (required since
@DataJpaTest was removed in Spring Boot 4.x) and a PostgreSQLContainer
via @ServiceConnection to verify save and retrieval against a real
postgres:18 database.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: wire spi-jpa into the application module ... d8d1ca14e1

Adds spi-jpa as a dependency, configures the datasource/JPA/Flyway
in application.yaml, and makes the context test use a Testcontainers
PostgreSQL container so it keeps passing without a running database.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: add spi-jpa to workflows with Docker socket support ... 526ab023f0

Adds infrastructure/spi-jpa to the test matrix in ci-feature.yaml and
as a sequential step in ci-develop.yaml. Mounts /var/run/docker.sock
in the Nix test containers so Testcontainers can reach the host daemon.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: add compose.yaml for local dev environment ... 2fc4a504c5

Starts a postgres:18 container with credentials matching application.yaml.
Volume is mounted at /var/lib/postgresql (not /data) as required by the
PostgreSQL 18 Docker image which places data in /var/lib/postgresql/18/docker.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: make feature test jobs self-contained ... aec8bab0bd

Each matrix test job now runs install -DskipTests before running
the module tests. The named volume between build-and-check and test
jobs is not guaranteed to be populated, so each test job installs
all local modules itself to avoid missing artifact errors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Revert "ci: make feature test jobs self-contained" ... f31979a8c4

This reverts commit aec8bab0bd.

ci: use -Dmaven.test.skip=true in build step ... f487325e0f

-DskipTests skips test execution but still compiles test code. If test
code fails to compile (e.g. a missing annotation), the build step fails
and spi-jpa is not installed to the cache, causing dependent modules to
fail with artifact-not-found.

-Dmaven.test.skip=true skips both compilation and execution, so the
build step only validates that production code compiles and all modules
are installable. Test compilation and execution happen exclusively in
the dedicated test steps.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: replace test matrix with sequential steps in feature workflow ... 38630edbdb

A single job with one step per module mirrors the develop workflow and
avoids cross-job artifact resolution issues entirely since all steps
share the same container and Maven cache.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: disable Ryuk and remove docker socket mount ... adc992dedf

The runner uses Docker-in-Docker (tcp://docker-in-docker:2375), not
the host socket. Ryuk (the Testcontainers resource reaper) fails in
DinD environments because it cannot connect back to itself. Disabling
it via TESTCONTAINERS_RYUK_DISABLED=true is the standard fix.

The /var/run/docker.sock volume mount is also removed since DinD is
already wired at the runner level and the socket was never used.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: pin Maven local repo to /root/.m2/repository via MAVEN_OPTS ... 3de997e214

nix develop may alter the effective HOME between invocations, causing
Maven to resolve its local repository at a path that differs from the
mounted maven-cache volume. Forcing -Dmaven.repo.local=/root/.m2/repository
in MAVEN_OPTS on every job ensures the install and test steps always
read from and write to the same volume-backed path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: replace Nix with maven:3-eclipse-temurin-25 ... 33bb9d4200

Nix added overhead (flake evaluation, HOME side-effects, /bin/sh
workaround) without providing value in CI where the environment only
needs Java 25 and Maven. The official Maven image ships both and is
predictable.

Removed: nixos/nix image, nix-store volume, NIX_CONFIG env var, nix
develop wrapper in the mvn action.
Kept: maven-cache volume, MAVEN_OPTS repo pinning, TESTCONTAINERS_RYUK_DISABLED.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: remove MAVEN_OPTS ... 4814846a51

No longer needed with the standard Maven image where HOME is stable.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: remove empty env blocks ... 6bc983420c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: trigger on pull_request only, not on push ... 7d482c3a2c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: feature on PR→develop, develop on push to develop ... 8b9598c91a

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jbwittner added 1 commit 2026-06-04 15:40:25 +00:00

Dimitris made me do it 2ae0fa1797

jbwittner added 1 commit 2026-06-04 15:48:33 +00:00

Revert "Dimitris made me do it" ... e37fd96e0c

This reverts commit 2ae0fa1797.

jbwittner merged commit 422e9f216d into develop 2026-06-04 15:50:11 +00:00

jbwittner deleted branch feature/spi-jpa-module 2026-06-04 15:50:11 +00:00

jbwittner referenced this pull request from a commit 2026-06-04 15:50:12 +00:00

feature/spi-jpa-module (#9)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

jbwittner/bankwiz_server!9

No description provided.